Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sessions sharedworker correctly shared for all deployments #15175

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix: sessions sharedworker correctly shared for all deployments #15175

merged 1 commit into from
Nov 5, 2024

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Nov 3, 2024 •
edited
Loading

No description provided.

@mroz22 mroz22 force-pushed the fix-sharing-of-sharedworker branch from e42c5fe to 3156f9a Compare November 4, 2024 12:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 9
  • More info

Learn more about 𝝠 Expo Github Action

@mroz22 mroz22 force-pushed the fix-sharing-of-sharedworker branch from 59afd96 to 6be2a0a Compare November 4, 2024 17:57
@mroz22 mroz22 changed the title wip fix: sessions sharedworker correctly shared for all deployments Nov 4, 2024
@mroz22 mroz22 force-pushed the fix-sharing-of-sharedworker branch from 6be2a0a to 2c38fe0 Compare November 5, 2024 11:28
martykan
martykan approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@martykan martykan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work

@mroz22 mroz22 marked this pull request as ready for review November 5, 2024 11:47
@mroz22 mroz22 requested a review from szymonlesisz as a code owner November 5, 2024 11:47
@mroz22 mroz22 enabled auto-merge (rebase) November 5, 2024 11:48
@mroz22
Copy link
Contributor Author

mroz22 commented Nov 5, 2024

/rebase

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11683735052

@trezor-ci trezor-ci force-pushed the fix-sharing-of-sharedworker branch from 7cc3123 to 1851181 Compare November 5, 2024 12:03
@mroz22 mroz22 merged commit 13ec59a into develop Nov 5, 2024
39 of 40 checks passed
@mroz22 mroz22 deleted the fix-sharing-of-sharedworker branch November 5, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martykan martykan martykan approved these changes

@szymonlesisz szymonlesisz Awaiting requested review from szymonlesisz szymonlesisz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroz22 @martykan